Make actionEvent of extension more specific#212
Open
FieteO wants to merge 1 commit into42Crunch:masterfrom
Open
Make actionEvent of extension more specific#212FieteO wants to merge 1 commit into42Crunch:masterfrom
FieteO wants to merge 1 commit into42Crunch:masterfrom
Conversation
Collaborator
|
Thanks for the PR! Unfortunately we can't quite get rid of activation on '*' at the moment. This extension contains two large chunks of functionality, one which is mostly self-contained and the other that requires user to configure credentials to access our cloud-based "42Crunch Platform". At the moment we conditionally enable some of that functionality at the launch of the VS Code, if user has indeed configured platform credentials, therefore we have to activate as soon as possible. We have plans to migrate away from using '*', but we are not quite ready to do it. |
Contributor
Author
|
Ah I see. Thanks for elaborating @ak1394 ! |
Collaborator
|
Thanks for taking an interest in it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a warning in the
package.jsonabout theactivationEvent:Using '*' activation is usually a bad idea as it impacts performance.As explained in the vscode docs, the
*corresponds to 'always activate'.This PR makes this actionEvent more specific. Ideally, the extension should only be activated for
jsonandyamlfiles using onLanguage:However the
deleteYamlNodetest case is failing then. Maybe it would make sense that someone with more experience of this project (@ak1394 ?) could take a look in a second step to improve this further