Conversation
|
Any chance you could link resource names and resource paths? I recently needed to rename a folder for organization and as a result needed to go through and change the file paths and the names of the resources individually to match those file paths.... And I don't see much of a purpose for them having different names than their paths which they default to. Nonetheless these changes you have planned would already had a huge layer of convenience to that so great work! |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e46fff0490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| const nextResource = resourcesManager.getResourceAt(nextIndex); | ||
| onSelectResource(nextResource); | ||
| }, |
There was a problem hiding this comment.
Use filtered list for arrow navigation
When a search filter is active, the list is rendered from filteredList, but arrow-key navigation still picks the next resource via the full manager list (getResourceAt(nextIndex) with an index derived from the full count). In that scenario, pressing Up/Down can select a resource that isn’t in the filtered view, leaving the selection invisible and actions (delete/rename) targeting a hidden resource. Consider computing the next index from the filtered list (or skipping navigation when the filter is non-empty) so keyboard selection stays within the visible list.
Useful? React with 👍 / 👎.
Add to the the resource list:
2.mp4