chore: update run.py#1295
Merged
jxnl merged 1 commit into567-labs:mainfrom Jan 9, 2025
eltociear:patch-3
Merged
Conversation
Verfication -> Verification
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3d47dcf in 13 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. examples/citations/run.py:75
- Draft comment:
The class nameAnswerWithCitatoncontains a typo. It should beAnswerWithCitation. This typo appears multiple times in the code (lines 40, 112, 170, 204). - Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. examples/citations/run.py:75
- Draft comment:
The class name 'AnswerWithCitaton' is misspelled. Consider renaming it to 'AnswerWithCitation'. This issue appears multiple times in the code. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_0fFj3ys6uRPfyviG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verfication -> Verification
Important
Fix typo in docstring of
Validationclass inrun.py, changing "Verfication" to "Verification".Validationclass inrun.py, changing "Verfication" to "Verification".This description was created by
for 3d47dcf. It will automatically update as commits are pushed.