Fix type issue with ListFilesResponse#495
Merged
64bit merged 2 commits into64bit:mainfrom Nov 28, 2025
Merged
Conversation
Owner
|
Fixed this in v0.31.1 (did a patch release because the latest release was very recent - so I do not expect high usage of it yet) |
ifsheldon
pushed a commit
to ifsheldon/async-openai-wasm
that referenced
this pull request
Dec 2, 2025
* Make ListFilesResponse.first_id and last_id Option * Add test cases for empty list files (cherry picked from commit 39d5116)
kraemahz
pushed a commit
to subseq-io/async-openai
that referenced
this pull request
Dec 12, 2025
* Make ListFilesResponse.first_id and last_id Option * Add test cases for empty list files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change!
When using
Files::list(), I found that if you have zero files in your account, it returns an error. But it should be able to parse the response in this case and return a result.I included a test case to demonstrate this behavior. Currently, the test will cause this unwrap error:
I changed the first_id field to a
Optionto mitigate this. However, this is a breaking change, so maybe it is better to use serde's default value for the string in case the field was null.I recommend changing all pagination id's for other structs the same way as well.