Fix ChatCompletionStreamOptions serialization for OpenAI-compatible providers#512
Merged
64bit merged 1 commit into64bit:mainfrom Jan 11, 2026
Conversation
Add serde attribute to omit None values for include_usage and include_obfuscation. Add tests to verify correct serialization and deserialization behavior.
64bit
approved these changes
Jan 11, 2026
Owner
64bit
left a comment
There was a problem hiding this comment.
Usually for this test is not required, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
include_obfuscationisNone, it is serialized as"include_obfuscation": nullinstead of being omitted from the JSON payload. Some OpenAI-compatible providers (e.g., NVIDIA NIM) reject requests containing unknown fields, causing errors like:Added
#[serde(skip_serializing_if = "Option::is_none")]to both fields inChatCompletionStreamOptions, soNonevalues are omitted from serialization rather than being sent asnull