Closed
Conversation
6uhrmittag
force-pushed
the
merge_open_forks
branch
from
f345a75 to
aba9f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: tmrts#52
##############################################################################################
This fixes #11
These changes provide support for private repos via https basic auth and/or ssh public keys.
This also removes the reliance on github and allows using other repos (github, bitbucket, etc)
@tmrts DO NOT MERGE THIS...
To get private repos / auth working requires upstream changes. They are as follows:
need support for hashed hostnames in crypto/ssh/knownhosts
A PR has been submitted to golang.org/x/crypto: https://go-review.googlesource.com/#/c/40532/
A matching PR has been made to src-d's fork of crypto: https://github.com/src-d/crypto/pull/2
need support for providing credentials to BasicAuth in go-git
A PR has been made here: added credentials provider for basic auth src-d/go-git#353
need gopkg.in/src-d/go-git.v4 rebased with master once these changes are pulled in
Once all of the above is complete, this PR can be merged.
In the meantime, I've vendored the dependencies in the bolir project and made the above changes to get it working. Attached is a zip file of the project with the vendored dependencies. You should be able to extract and run go install to test it out.