Open
Conversation
When no table name is provided in serverless.yml, use the dynamic generated table name
Author
|
@AshanFernando please review this |
| if (!resources[key].Properties.TableName) { | ||
| const service = this.service.service; | ||
| const stage = this.options.stage || this.service.provider.stage; | ||
| resources[key].Properties.TableName = `${service}-${stage}-${key}`; |
There was a problem hiding this comment.
By adding the service name to the TableName it can pretty easily reach the 256 char max length that DynamoDB has for its name. What about limiting the name to stage-key?
Suggested change
| resources[key].Properties.TableName = `${service}-${stage}-${key}`; | |
| resources[key].Properties.TableName = `${stage}-${key}`; |
|
This works great for me - would be nice to see it merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #107
Changes: When no table name is provided in
serverless.yml, use the dynamic generated table name