docs(pylibafl): clarify maturin must be run from bindings directory#3689
Open
Aditya30ag wants to merge 2 commits intoAFLplusplus:mainfrom
Open
docs(pylibafl): clarify maturin must be run from bindings directory#3689Aditya30ag wants to merge 2 commits intoAFLplusplus:mainfrom
Aditya30ag wants to merge 2 commits intoAFLplusplus:mainfrom
Conversation
Member
|
How did you find the readme in the first place? Aren't you already in the folder by then? |
Contributor
Author
|
@domenukk Initially tried running the command from the workspace root. As not mentioned in the readme on which path we should run the commands |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running maturin develop from the LibAFL workspace root fails because the root Cargo.toml is a workspace and does not contain a [package] section. The command only works when run from bindings/pylibafl, which contains the actual Python extension crate.
so i think we should mention the correct directory .
Checklist
./scripts/precommit.shand addressed all commentsclosing issue #3688