Skip to content

fix: update summary status logic to reflect suppression state #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpreen merged 2 commits into from
Jan 28, 2026
Merged

fix: update summary status logic to reflect suppression state #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d000d4
fix: update summary status logic to reflect suppression state
JessUWE Jan 28, 2026
e86a2b4
fix: update summary status in tests to reflect review state
JessUWE Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions acro/acro_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,19 +1252,19 @@ def get_summary(sdc: dict) -> tuple[str, str]:
else:
if sdc_summary["threshold"] > 0:
summary += f"threshold: {sdc_summary['threshold']} cells {sup}; "
status = "fail"
status = "review" if sdc_summary["suppressed"] else "fail"
if sdc_summary["p-ratio"] > 0:
summary += f"p-ratio: {sdc_summary['p-ratio']} cells {sup}; "
status = "fail"
status = "review" if sdc_summary["suppressed"] else "fail"
if sdc_summary["nk-rule"] > 0:
summary += f"nk-rule: {sdc_summary['nk-rule']} cells {sup}; "
status = "fail"
status = "review" if sdc_summary["suppressed"] else "fail"
if sdc_summary["all-values-are-same"] > 0:
summary += (
f"all-values-are-same: {sdc_summary['all-values-are-same']} "
f"cells {sup}; "
)
status = "fail"
status = "review" if sdc_summary["suppressed"] else "fail"
if summary != "":
summary = f"{status}; {summary}"
else:
Expand Down
12 changes: 6 additions & 6 deletions test/test_initial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_crosstab_threshold(data, acro):
assert np.isnan(output.output[0].iloc[row, col])
acro.add_exception("output_0", "Let me have it")
results: Records = acro.finalise(PATH)
correct_summary: str = "fail; threshold: 6 cells suppressed; "
correct_summary: str = "review; threshold: 6 cells suppressed; "
output = results.get_index(0)
assert output.summary == correct_summary
shutil.rmtree(PATH)
Expand All @@ -111,7 +111,7 @@ def test_crosstab_multiple(data, acro):
acro.add_exception("output_0", "Let me have it")
results: Records = acro.finalise(PATH)
correct_summary: str = (
"fail; threshold: 7 cells suppressed; p-ratio: 2 cells suppressed; "
"review; threshold: 7 cells suppressed; p-ratio: 2 cells suppressed; "
"nk-rule: 1 cells suppressed; "
)
output = results.get_index(0)
Expand Down Expand Up @@ -174,7 +174,7 @@ def test_pivot_table_cols(data, acro):
acro.add_exception("output_0", "Let me have it")
results: Records = acro.finalise(PATH)
correct_summary: str = (
"fail; threshold: 14 cells suppressed; "
"review; threshold: 14 cells suppressed; "
"p-ratio: 4 cells suppressed; nk-rule: 2 cells suppressed; "
)
output_0 = results.get_index(0)
Expand Down Expand Up @@ -332,7 +332,7 @@ def test_output_removal(data, acro, monkeypatch):
# remove something that is there
acro.remove_output(output_0.uid)
results = acro.finalise(PATH)
correct_summary: str = "fail; threshold: 6 cells suppressed; "
correct_summary: str = "review; threshold: 6 cells suppressed; "
keys = results.get_keys()
assert output_0.uid not in keys
assert output_1.uid in keys
Expand Down Expand Up @@ -646,7 +646,7 @@ def test_surv_func(acro):
# table
_ = acro.surv_func(data.futime, data.death, output="table")
output = acro.results.get_index(0)
correct_summary: str = "fail; threshold: 3864 cells suppressed; "
correct_summary: str = "review; threshold: 3864 cells suppressed; "
assert output.summary == correct_summary

if not skip_exact_assertion:
Expand Down Expand Up @@ -686,7 +686,7 @@ def test_zeros_are_not_disclosive(data, acro):
acro.add_exception("output_0", "Let me have it")
results: Records = acro.finalise(PATH)
correct_summary: str = (
"fail; threshold: 14 cells suppressed; "
"review; threshold: 14 cells suppressed; "
"p-ratio: 2 cells suppressed; nk-rule: 2 cells suppressed; "
)
output_0 = results.get_index(0)
Expand Down