Skip to content

refactor: update rounded_survival_table to use dynamic column names#332

Merged
rpreen merged 2 commits intomainfrom
323-task-review-rounded_survival_table-code
Feb 5, 2026
Merged

refactor: update rounded_survival_table to use dynamic column names#332
rpreen merged 2 commits intomainfrom
323-task-review-rounded_survival_table-code

Conversation

@JessUWE
Copy link
Contributor

@JessUWE JessUWE commented Feb 5, 2026

No description provided.

@JessUWE JessUWE linked an issue Feb 5, 2026 that may be closed by this pull request
@JessUWE JessUWE changed the title Refractor: updated rounded_survival_table to use dynamic column names Refactor: updated rounded_survival_table to use dynamic column names Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (5194ad1) to head (4c68ff5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files           9        9           
  Lines        1273     1273           
=======================================
  Hits         1272     1272           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JessUWE JessUWE requested a review from rpreen February 5, 2026 11:48
@rpreen rpreen changed the title Refactor: updated rounded_survival_table to use dynamic column names refactor: update rounded_survival_table to use dynamic column names Feb 5, 2026
… mark it as an internal helper function

- Add comprehensive type hints to function signature and return type
- Add parameter and return type annotations: pd.DataFrame, str
- Add detailed NumPy-style docstring documenting parameters, return value, and purpose
- Update test imports to use the new private function name
@JessUWE JessUWE requested a review from rpreen February 5, 2026 18:39
@rpreen rpreen merged commit 0be706a into main Feb 5, 2026
5 checks passed
@rpreen rpreen deleted the 323-task-review-rounded_survival_table-code branch February 5, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[task] review rounded_survival_table() code

2 participants