Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
requested review from
AngeloDanducci,
ajbozarth,
george-lhj,
maximilien,
planetf1 and
psschwei
george-lhj
reviewed
Nov 4, 2025
| zap.String("workflow_file", workflowFile)) | ||
|
|
||
| // Start the API server using ServeWorkflow in a goroutine | ||
| apiErrChan := make(chan error, 1) |
There was a problem hiding this comment.
I'm not seeing where we read from this channel, if the API server fails immediately, the error goes into the channel but we only get the generic "failed to become healthy" error at line 524, If the server crashes after we return, the channel buffer fills up and the goroutine might block I think.
Is the intent to check this channel during waitForAPIHealth to catch early failures? In any case, it doesn't seem like apiErrChan is read from anywhere afaik? Not sure
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
george-lhj
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the node ui in workflow deploy command.