Add WalletDb Initialization to StorageNode::new() in src/storage.rs#106
Open
Sophie-Ag00001 wants to merge 1 commit intomainfrom
Open
Add WalletDb Initialization to StorageNode::new() in src/storage.rs#106Sophie-Ag00001 wants to merge 1 commit intomainfrom
Sophie-Ag00001 wants to merge 1 commit intomainfrom
Conversation
…Node::new() function in src/storage.rs, similar to the WalletDb initialization in src/miner.rs. ONLY WORK ON src/storage.rs, NO OTHER FILES. DO NOT DELETE ANY CODE OR FILES.
BHouwens
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Add WalletDb Initialization to StorageNode::new()
Summary of Changes
This pull request implements the initialization of a new
WalletDbinstance within theStorageNode::new()function located insrc/storage.rs. This modification mirrors the existingWalletDbinitialization found insrc/miner.rs.Motivation
The primary motivation for these changes is to ensure a consistent initialization procedure for the
WalletDbacross different components of the application, particularly enhancing the management and accessibility of wallet-related data within the storage node.Relevant Context
The
WalletDbserves a critical role in managing wallet data, and its appropriate initialization within theStorageNodewill enable better data integrity and retrieval processes. Aligning the initialization across modules also fosters code consistency and maintainability.Testing Instructions
StorageNodeoperates as expected with the newWalletDbinitialization.WalletDb.Known Issues / Limitations
src/storage.rswere modified.Thank you for your consideration! Looking forward to your feedback.