Refactor: Remove Multi-Node Tests, Retain Single Node Tests in tests.rs#93
Closed
Sophie-Ag00001 wants to merge 1 commit intomainfrom
Closed
Refactor: Remove Multi-Node Tests, Retain Single Node Tests in tests.rs#93Sophie-Ag00001 wants to merge 1 commit intomainfrom
Sophie-Ag00001 wants to merge 1 commit intomainfrom
Conversation
"*_2_nodes" "*_3_nodes" "*_15_nodes" "*majority_3_nodes" "*majority_15_nodes" "*_multi_miners_raft_2_nodes" Keep single node tests: Keep all "_1_node" tests Keep "no_raft" tests Keep "_raft_real_db_1_node" tests Remove these specific multi-node functions: full_flow_raft_2_nodes full_flow_raft_3_nodes full_flow_raft_majority_3_nodes full_flow_raft_majority_15_nodes full_flow_multi_miners_raft_2_nodes full_flow_raft_kill_forever_*_node_3_nodes full_flow_raft_kill_*_node_3_nodes full_flow_raft_dis_and_re_connect_*_node_3_nodes The goal is to only keep tests that operate on a single node setup. All tests involving multiple nodes communicating with each other should be removed. ONLY work on tests.rs, DO NOT edit any other files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Refactor Tests to Focus on Single Node Setup
Summary of Changes
This PR removes tests that involve multi-node setups while retaining only those that operate on a single node. Specifically, tests with the following patterns have been removed:
"*_2_nodes""*_3_nodes""*_15_nodes""*majority_3_nodes""*majority_15_nodes""*_multi_miners_raft_2_nodes"Additionally, the following specific multi-node functions have been deleted:
full_flow_raft_2_nodesfull_flow_raft_3_nodesfull_flow_raft_majority_3_nodesfull_flow_raft_majority_15_nodesfull_flow_multi_miners_raft_2_nodesfull_flow_raft_kill_forever_*_node_3_nodesfull_flow_raft_kill_*_node_3_nodesfull_flow_raft_dis_and_re_connect_*_node_3_nodesThe focus has been maintained on keeping single node tests, such as:
_1_nodetestsno_raft_raft_real_db_1_nodeMotivation
The primary motivation behind this change is to streamline the testing process by eliminating unnecessary complexity associated with multi-node communications. Concentrating on single node testing ensures more straightforward debugging and more efficient use of resources during testing.
Relevant Context
This refactor is part of an ongoing effort to enhance testing clarity and efficiency. By maintaining a clear separation between single and multi-node tests, we aim to facilitate better maintenance and understanding of test outcomes.
Instructions for Testing Changes
cargo testin thetests.rsfile.Known Issues or Limitations
There are no known issues following this change. This refactor strictly adheres to the specified requirements of only altering
tests.rswithout impacting other files.Feel free to reach out if you have any questions or require further clarification on the modifications made!