Skip to content

Opamp test case using poor man's cascode#1115

Merged
soneryaldiz merged 2 commits intomasterfrom
opamp_poor
May 24, 2022
Merged

Opamp test case using poor man's cascode#1115
soneryaldiz merged 2 commits intomasterfrom
opamp_poor

Conversation

@soneryaldiz
Copy link
Collaborator

@srini229 , this PR adds one of the test circuits we discussed earlier. The test is currently failing:
2022-05-23 20:32:46 PnR.placer.Placer.setPlacementInfoFromJson ERROR : instance_name: X_I0 concrete_template_name: NMOS_4T_38150412_X2_Y1 not found.

@soneryaldiz soneryaldiz requested a review from srini229 May 24, 2022 03:36
@soneryaldiz soneryaldiz marked this pull request as ready for review May 24, 2022 03:36
@srini229 srini229 self-assigned this May 24, 2022
@srini229
Copy link
Collaborator

@soneryaldiz do you want to use this PR to fix the failing test before merging?

@soneryaldiz
Copy link
Collaborator Author

Yes, let's fix if there is an issue. A variant, despite being generated, is not found by the placer. @854768750 , could you please take a look? To reproduce: pytest -vv -s -k opamp_poor

@854768750
Copy link
Collaborator

854768750 commented May 24, 2022 via email

@stevenmburns
Copy link
Collaborator

@soneryaldiz @854768750 This looks like the same problem as #1083 which is still pending. We might need a new start on it because what we have there now is worse than master.

@stevenmburns
Copy link
Collaborator

The issue is when the placement is read back into the router. To see this, try:

schematic2layout.py $ALIGN_HOME/tests/pdk/finfet_pdk/ckt_opamp_poor -p $ALIGN_HOME/align/pdk/finfet -l INFO -n 8 --flow_stop 3_pnr:gui
schematic2layout.py $ALIGN_HOME/tests/pdk/finfet_pdk/ckt_opamp_poor -p $ALIGN_HOME/align/pdk/finfet -l INFO -n 8 --flow_start 3_pnr:route

@854768750
Copy link
Collaborator

Yes, let's fix if there is an issue. A variant, despite being generated, is not found by the placer. @854768750 , could you please take a look? To reproduce: pytest -vv -s -k opamp_poor

@soneryaldiz This is the same issue as #1083

@srini229
Copy link
Collaborator

I tried to run this test after merging the changes from branch fix/multi_variant_placement_injection from #1083 to this branch. The test passes.

@soneryaldiz
Copy link
Collaborator Author

@stevenmburns and I decided to reduce variants to 1 to merge this PR. The known issue to be resolved in a future PR.

Copy link
Collaborator

@srini229 srini229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soneryaldiz soneryaldiz merged commit 4d377bd into master May 24, 2022
@soneryaldiz soneryaldiz deleted the opamp_poor branch May 24, 2022 23:54
@soneryaldiz soneryaldiz assigned soneryaldiz and unassigned srini229 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants