Create Read data from another Plus via HTTP GET.js#69
Open
frspp wants to merge 1 commit intoALLTERCO:mainfrom
Open
Create Read data from another Plus via HTTP GET.js#69frspp wants to merge 1 commit intoALLTERCO:mainfrom
frspp wants to merge 1 commit intoALLTERCO:mainfrom
Conversation
taulfsime
requested changes
May 4, 2024
Collaborator
taulfsime
left a comment
taulfsime
left a comment
There was a problem hiding this comment.
Thank you for the contribution, good example with comments explaining important lines.
Some nits and please register it in the readme and the manifest file.
|
|
||
| // Settings | ||
| let ip = 'ip'; | ||
| let username = 'admin'; // do not change, it is always admin |
Collaborator
There was a problem hiding this comment.
Not needed, since as the comment said its always 'admin'.
| // Send HTTP get request with authentication | ||
| Shelly.call( | ||
| "HTTP.GET", { | ||
| "url": "http://" + username + ":" + password + "@" + ip + "/rpc/Switch.GetStatus?id=0", |
Collaborator
There was a problem hiding this comment.
Please move the url compilation outside of the request params.
| }, | ||
| function(result) { | ||
| // print(result.body); // Uncomment to see all available values. | ||
| let totalwh = JSON.parse(result.body).aenergy.total; // Reminder: On a Plus device energy total is in Watt-hours. On Gen1 device it is Watt-minutes. |
Collaborator
There was a problem hiding this comment.
Save the parsed body to an variable and then use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.