Skip to content

fix: Improve error handling in whisper_transcription_controller #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YadavAkhileshh wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix: Improve error handling in whisper_transcription_controller #694

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92d6c88
fix: replace print() with log() and add user error feedback in whispe…
YadavAkhileshh Jan 7, 2026
e6067b5
fix: address review feedback - single snackbar and cleaner loop
YadavAkhileshh Jan 18, 2026
af3261e
fix: add segment index back to debug logs using asMap().entries
YadavAkhileshh Jan 18, 2026
6c5aa15
fix: simplify to boolean flag with original for-in loop
YadavAkhileshh Jan 18, 2026
9e26938
fix: localize snackbar text for transcription warning
YadavAkhileshh Jan 18, 2026
28c7dc5
merge: resolve conflict with upstream/dev
YadavAkhileshh Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions lib/controllers/whisper_transcription_controller.dart
View file
Open in desktop
Copy link
Contributor

@M4dhav M4dhav Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the loop logic to like it was before, much simpler. No need to keep a count of the segments. Just use a boolean to check whether some part has failed.

Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import 'package:ffmpeg_kit_flutter_new/return_code.dart';
import 'package:get/get.dart';
import 'package:path_provider/path_provider.dart';
import 'package:resonate/utils/constants.dart';
import 'package:resonate/utils/enums/log_type.dart';
import 'package:resonate/views/widgets/snackbar.dart';
import 'package:whisper_flutter_new/whisper_flutter_new.dart';

class WhisperTranscriptionController extends GetxController {
Expand Down Expand Up @@ -59,6 +61,9 @@ class WhisperTranscriptionController extends GetxController {
final StringBuffer lrcContent = StringBuffer();
lrcContent.writeln('[re:Resonate App - AOSSIE]');
lrcContent.writeln('[ve:v1.0.0]');

bool hasFailedSegments = false;

for (WhisperTranscribeSegment? segment in transcriptionSegments) {
try {
// Parse the log line
Expand All @@ -67,11 +72,25 @@ class WhisperTranscriptionController extends GetxController {
// Convert to LRC format and add to content
lrcContent.writeln(segmentString);
}
} catch (e) {
print(e.toString());
} catch (e, stackTrace) {
log(
'Error converting transcription segment: ${e.toString()}',
error: e,
stackTrace: stackTrace,
);
hasFailedSegments = true;
}
}

// Show a single user-friendly snackbar if any segments failed
if (hasFailedSegments) {
customSnackbar(
'Transcription Warning',
'Some parts of the transcription could not be processed.',
Copy link
Contributor

@M4dhav M4dhav Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localize the snackbar text

Copy link
Author

@YadavAkhileshh YadavAkhileshh Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Snackbar text is now localized

LogType.warning,
);
}

return lrcContent.toString();
}

Expand Down