You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I rebased on experimental_compilers and did some changes to support GCC. I split the K22F part into mbrossard:feature/k22f_hic, and the KW38 interfaces in mbrossard:feature/k22f_kw38_if. I was able to do some smoke testing with a FRDM-K22F (it seems with current configuration the HIC thinks the reset button is pushed, so it will always jump into bootloader).
I have a few questions:
Why did you change the HIC ID?
It seems the bootloader also has some compilation time assert to check the bootloader and interface sizes are 32 KB and 96 KB respectively. So I made the changes in daplink_addr.h to limit Flash to 128 KB, and limited RAM to 24 KB. Those changes make it possible to target MCUs from the K22_100 sub-family (like MK22FN128*10) in addition to the ones in K22_120 (like MK22FN512*12). Was this your intent also when you chose the bl/if sizes?
There is a K22_50 sub-family and I was wondering if this is why you chose to use 48 MHz clock?
What is the reason for using #if defined(IINTERFACE_K22F) in source/hic_hal/freescale/k22f/gpio.c? It seems to me the INTERFACE_K22F is always set (for both bootloader and interface).
Without the proper hardware it is not possible for me to fully test. If you can test and fix on top of the feature/k22f_hic and update your PR to target experimental_compilers. I would prefer to keep the PR for HIC and boards separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team,
I would like to add a new HIC device K22F and KW38-ER-RD board from NXP to the repo. Can you please check it?
Thank you in advance.
Best regards,
Karel Povalac