Disable any tags not used in current OSM file#6
Open
hamiltont wants to merge 4 commits intoAbsolute-Tinkerer:masterfrom
Open
Disable any tags not used in current OSM file#6hamiltont wants to merge 4 commits intoAbsolute-Tinkerer:masterfrom
hamiltont wants to merge 4 commits intoAbsolute-Tinkerer:masterfrom
Conversation
A common problem with OSM is the overload of information that beginners get. Most maps don't use all of the tags, so this adds an optional button to auto-disable any tags that are not used in your map selection. This prevents the "click-then-squint" pattern of trying to see what, if anything, changed in the map
I can't think of a reason someone would enable this option, so I just made it the default from now on
The user interface is the only one that actually needs this cache, and it's the best positioned to understand when it needs to be refreshed (when the file is reloaded). This commit also handles ensuring we disable the parent items, and also that we don't get a crash if there are no enabled parents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds a new feature - each time you reload the OSM file, it will scan the file for all tag key/value pairs. Any tag pairs not found will be disabled in the GUI, making it far easier to see what options you could tweak to change the render of this specific OSM datafile. It does not actually change your config settings, e.g. disabled options are not unchecked
IMO this addresses a common problem with OSM data for beginners - the overload of available information