Skip to content

ICA Client testing#486

Draft
Kayanski wants to merge 54 commits intomainfrom
ica-client/tests-move
Draft

ICA Client testing#486
Kayanski wants to merge 54 commits intomainfrom
ica-client/tests-move

Conversation

@Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Oct 7, 2024 •
edited
Loading

This Pr aims at moving and testing the ICA client based on Abstract V2.

  • ICA Client is a native module for now but is not installable by users (The IBC Client is the only native module that can be installed)
  • ICA Client has a lot of pre-requisites to work (it necessitates IBC channels and IBC forwarder)
  • It is dependent on the EVM note being registered inside abstract.
    • Should we create a deployment flow that includes both to make sure everything is registered when deploying abstract ?
    • I think that the deployment flow of the ICA client and the Polytone EVM implementation need to follow the exact same flow as our current Polytone and Abstract flow

Testing is extremely limited because UNION is VERY SLOW to commit packets receive and acks.

The file containing the test can be found here: https://github.com/AbstractSDK/abstract/pull/486/files#diff-91fd048063bac99685bc53380e57097196063977ab6782ecd820c3d759b2eeea

Checklist

  • CI is green.
  • Changelog updated.

@Kayanski Kayanski mentioned this pull request Oct 7, 2024
Closed
2 tasks
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e078c2
Status: ✅  Deploy successful!
Preview URL: https://74104c76.abstract-docs.pages.dev
Branch Preview URL: https://ica-client-tests-move.abstract-docs.pages.dev

View logs

Kayanski and others added 12 commits October 8, 2024 09:34
@Kayanski
Fix and update
421021c
@Kayanski
Update cw-orch cw-orch-interchain, polytone
743af86
@Kayanski
formatting [skip ci]
340ab11
@Kayanski
Merge branch 'develop/v2' into nicolas/abs-534-review-interchain-abst…
279e7b1 
…ract-testing-setup-for-interchain-v2
@Kayanski
Re-added cw-orch-proto dependent tests
00d6584
@Kayanski
Merge branch 'nicolas/abs-534-review-interchain-abstract-testing-setu…
452add9 
…p-for-interchain-v2' of github.com:AbstractSDK/abstract into nicolas/abs-534-review-interchain-abstract-testing-setup-for-interchain-v2
@Kayanski
Merge remote-tracking branch 'origin/nicolas/abs-534-review-interchai…
42b837b 
…n-abstract-testing-setup-for-interchain-v2' into ica-client/tests-move
@Buckram123
small-wasm
ba0fd34
@Kayanski
compiling wasm
b7e9d8c
@Buckram123
remove ibc client message
1f41822
@Buckram123
Avoid usage of instantiate msg for sub account creation
b253c0a
@Kayanski
Final ica client test
836f3b4
@Kayanski Kayanski changed the base branch from develop/v2 to v2/small-wasm October 9, 2024 13:40
Base automatically changed from v2/small-wasm to develop/v2 October 10, 2024 10:52
Base automatically changed from develop/v2 to main October 16, 2024 13:11
@Kayanski Kayanski requested a review from Buckram123 October 22, 2024 12:58
Buckram123
Buckram123 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Would be nice to update chain type lookup table, other than that small nits 🚀

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

Assignees

No one assigned

Labels

account documentation Improvements or additions to documentation interface native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kayanski @Buckram123 @CyberHoward