Skip to content

Use OBJ in OSL render testing#2733

Open
ld-kerley wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
ld-kerley:osl/use-sphere-obj
Open

Use OBJ in OSL render testing#2733
ld-kerley wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
ld-kerley:osl/use-sphere-obj

Conversation

@ld-kerley
Copy link
Contributor

Update OSL render testing to use sphere.obj instead of the built in sphere primitive in test shade - thanks to @fpsunflower for adding OBJ reading support to OSL testrender.

In order to align with GLSL/MSL testing we remove texture coordinate flipping in GLSL/MSL. After talking to Jonathan, he thinks perhaps we've been rendering the unit tests upside-down since the flip was introduced. We may decide we need to invert the texture reading to re-instate texture orientation. We will re-evaluate this after this is merged.

Remove local OSL render test override tangent/bitangent nodes. Now we're using OBJ we get the correct result for the geometry directly from test render.

Update OSL render template instantiation to write absolute paths to make debugging externally easier.

…inate flipping in GLSL/MSL render test to ensure the renders align.

This may mean the UVs are flipped - and we will re-evaluate this after this is merged.
Remove local tangent/bitangent nodes now we're using OBJ
Update OSL render template to write absolute paths to make debugging externally easier.
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really promising, thanks @ld-kerley, and my sense is that we'll learn a great deal by running a new set of reference quality GLSL/OSL render tests, to see how the latest set compares with previous ones. I can run these tests on my side when time permits, or you potentially give them a try in your own environment.

One interesting outcome to watch for is whether this change improves the parity of our GLSL/OSL render tests, e.g. by providing more consistent surface normals and tangent frames across the two rendering environments.

Copy link
Contributor

@chellmuth chellmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants