Add GraphState to Graph Editor#2762
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Jan 31, 2026
Merged
Add GraphState to Graph Editor#2762jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist introduces a `GraphState` struct to encapsulate the UI state for a graph level in the MaterialX Graph Editor. The following are some of the key improvements included in this change: - Consolidate scattered variables for the UI state of a graph level into a single `GraphState` struct. - Simplify nodegraph navigation by merging parallel stacks into a single `_parentStates` vector. - Split the `_initial` flag into `_needsLayout` and `_needsNavigation` for clarity. - Fix a subtle bug in `UiPin::deleteConnection`, where a loop break and reset of the `_connected` flag were missing.
lfl-eholthouser
approved these changes
Jan 31, 2026
Contributor
lfl-eholthouser
left a comment
lfl-eholthouser
left a comment
There was a problem hiding this comment.
This looks great! Thanks @jstone-lucasfilm!
jstone-lucasfilm
merged commit 9b1e277
into
AcademySoftwareFoundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist introduces a
GraphStatestruct to encapsulate the UI state for a graph level in the MaterialX Graph Editor. The following improvements are included:GraphStatestruct._parentStatesvector._initialflag into_needsLayoutand_needsNavigationfor clarity.UiPin::deleteConnection, where a loop break and reset of the_connectedflag were needed for completeness.