Graph Editor improvements for edges and links#2764
Open
jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
Graph Editor improvements for edges and links#2764jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist improves the robustness and maintainability of edge and link management in the MaterialX Graph Editor, including the following specific changes: - Consolidate duplicated edge creation and erasure into `Graph::createEdge` and `UiNode::eraseEdge` methods. - Synchronize `Graph::removeEdge` and `Graph::deleteNode` with the global edge list, fixing cases where stale edges could persist. - Simplify `Graph::edgeExists` and `Graph::linkExists` implementations for clarity, taking arguments by const reference. - Replace the static ID counter in `Link` with explicit construction through `GraphState::nextUiId`. - Add bounds and null checks across edge and link operations to prevent undefined behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist improves the management of edges and links in the MaterialX Graph Editor, including the following specific changes:
Graph::createEdgeandUiNode::eraseEdgemethods.Graph::removeEdgeandGraph::deleteNodewith the global edge list, fixing cases where stale edges could persist.Linkwith explicit construction throughGraphState::nextUiId.Graph::edgeExistsandGraph::linkExistsimplementations for clarity, taking arguments by const reference.