Clarified wording following SIGGRAPH report#288
Open
portsmouth wants to merge 1 commit intoAcademySoftwareFoundation:dev_1.2from
Open
Clarified wording following SIGGRAPH report#288portsmouth wants to merge 1 commit intoAcademySoftwareFoundation:dev_1.2from
portsmouth wants to merge 1 commit intoAcademySoftwareFoundation:dev_1.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to address the outstanding points discussed in #269.
These were already addressed in #253:
Here I address the other issues.
Thin-walled mode.
It was a bit unclear in the subsurface case that there is intended to be a dielectric slab embedding the thin-wall SSS "dense sheet", where the boundaries of the dielectric provide the specular lobe as usual.
The new text makes that more explicit. An issue is then that technically, light should bounce around inside the slab between the dense sheet and the dielectric walls, causing darkening. We could attempt to define something to get rid of that, but it gets too technical I think. I feel the best approach here is to simply say that that those effects should in theory be accounted for.
We already said the same effectively for the translucent dielectric case, since we said:
That ladder generates IOR-dependent darkening. It seems consistent to simply mention that this similar physical effect occurs in the subsurface case, without adding any special mechanism to get rid of it. In practice, implementations could reasonably just ignore this (e.g. MaterialX), though this produces some inaccuracy/unphysicality in the appearance. We could perhaps work out a nicer approximation to apply, and provide it in the MaterialX graph though.
I also made it more explicit that the diffuse lobes of the subsurface model are required to be EON diffuse lobes, which seems reasonable (and already the case in the MaterialX graph).
As I noted in the technical report, I really feel that this thin-wall model is too loosely defined still at present. A problem is that there is no one publication that works out the necessary BSDFs in full detail. It also seems a bit ad-hoc to have these two separate models of "dielectric sheet with embedded stufff", with either no scattering or dense scattering (the latter a rather crude approximation as well, with Oren-Nayar lobes involved).
It would be better to have available a more general "thin-slab of arbitrary volume" as a primitive:
This will have to be left for future work though. At present, this is as close as we could get to a completely physically specified thin-wall model.
Subsurface and glossy-diffuse albedos
I think a reasonable fix for these is simply to say explicitly that the definitions made are supposed to be applied assuming vacuum exterior (for the subsurface or glossy-diffuse slabs). This serves to define the BSDFs and media, then the more general case involving superimposed layers will follow from that.
(These definitions still seem extremely academic, and I'm skeptical that anyone has actually studied them and modified their implementation accordingly. I'm assuming almost everyone, or actually everyone, simply uses an approximate albedo-scaling approach. The current text is an attempt to make it more physically general than simply assuming albedo-scaling based layering approximation, but done in a way which ensures that albedo-scaling is not a bad approximation. Perhaps there is a better way to define this, at a later stage, that seems less esoteric).