Feature: Ability to sparsely gather scalar values and connect them to elements of a dynamic or statically sized array parameter#1826
Open
sfriedmapixar wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
…ay input. This requires you to first declare a setting for the dynamic array input that will be used to size and provide values for any unconnected elements of the dynamically sized array. After that, individual scalar->arrayelem connections can be specified from any number of different upstream shading nodes. This facilitates gathering inputs from across your shading network, for example several procedurally generated color signals and using them to drive inputs to shading nodes that are best left dynamically sized, such as the inputs to spline operations. This includes a new test in vararray-scalar-connect to demonstrate and test the new connection method. : Signed-off-by: Stephen Friedman <sfriedma@pixar.com>
… to init the values that upstream nodes will overwrite, so remove that to simplify. Signed-off-by: Stephen Friedman <sfriedma@pixar.com>
Contributor
|
This seems very useful. We currently achieve the same thing with shaders which take N scalar inputs and output arrays of length N, which isn't very elegant. Seems like the PR has been stale for a while - is there any chance of it being revived? |
Collaborator
|
I'm not sure how this slipped through the cracks; apologies about that. I'm in favor of this generally. @sfriedmapixar, can you please rebase on the current main, and then I promise I will quickly review and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.