Skip to content

Build fixes#59

Open
richardssam wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
richardssam:build_fixes
Open

Build fixes#59
richardssam wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
richardssam:build_fixes

Conversation

@richardssam
Copy link
Collaborator

These are build fixes, suggested by gemini to get the front-end app started up using npm run dev

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 2, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

Removing duplicate.

Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Resolve ambiguous exports in `index.ts` by removing wildcard export from `types.ts` and aliasing `User` from `apiHandler.ts`.

Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Fix TypeScript error in `apiHandler.test.ts` by casting mocked function to `Mock` type.

Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam Richards <sam.richards@taurich.org>
### Configuration

The frontend requires connection to the backend API.
Create a `.env` file in `packages/app/` with the following content:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a file called .env.example and change this to copy that file? Also add that to the QUICKSTART.md file.

*/

export * from './types';
// export * from './types'; // Conflict with interfaces
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is throwing an error here with the wide exports and types?

Default .env file for local backend.
@richardssam
Copy link
Collaborator Author

richardssam commented Feb 2, 2026 via email

@jspada200
Copy link
Collaborator

I reversed out those changes, and it did launch, but I am getting warnings about the exports in the editor. Module './types' has already exported a member named 'Playlist'. Consider explicitly re-exporting to resolve the ambiguity.ts(2308) Module './types' has already exported a member named 'Version'. Consider explicitly re-exporting to resolve the ambiguity.ts(2308) Module './interfaces' has already exported a member named 'User'. Consider explicitly re-exporting to resolve the ambiguity.ts(2308) Sam.

On Mon, 2 Feb 2026 at 21:33, James Spadafora @.> wrote: @.* commented on this pull request. ------------------------------ In frontend/packages/core/src/index.ts <#59 (comment)> : > @@ -5,9 +5,14 @@ * Contains shared utilities, types, and business logic. / -export * from './types'; +// export * from './types'; // Conflict with interfaces What is throwing an error here with the wide exports and types? — Reply to this email directly, view it on GitHub <#59 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2TR2BDFM6KOASU4NWATSD4J67CVAVCNFSM6AAAAACTXOORR2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONBRG43DMNJZGI . You are receiving this because you were mentioned.Message ID: @.**>

Ah got ya! That is one of typescript's default errors. I did global exports from these since we are moving quickly. For now, ignore these errors. We may try to eliminate ts errors at a later date. For context, we have a massive project at ILM and this is one of the errors we flagged as ignore since these export files would be massive. It is more of a style choice then an issue.

@@ -0,0 +1 @@
VITE_API_BASE_URL=http://localhost:8000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env files should be in the ignore to prevent accidental exposure of API keys when added later. Maybe we can add a fallback to localhost:8000 in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants