Open
Conversation
richardssam
force-pushed
the
notes_publish
branch
from
7312818 to
6d3423b
Compare
- Add [publish_note](cci:1://file:///Users/sam/git/dna/backend/src/dna/prodtrack_providers/shotgrid.py:601:4-699:27) method to ShotGrid provider with duplicate checking - Implement [sudo](cci:1://file:///Users/sam/git/dna/backend/src/dna/prodtrack_providers/shotgrid.py:179:4-199:55) context manager for author attribution, taking advantage of the sudo_as_login property. - Add `/publish-notes` and `/draft-notes` endpoints - Add PublishNotesRequest/Response models - Add unit tests for provider and endpoints Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
- Add `PublishNotesDialog` component - Create `usePublishNotes` and `usePlaylistDraftNotes` hooks - Add API methods for publishing - Add "Publish Notes" button to Sidebar Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
* adding methods for notes publishing. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
…t it as a new "publish". - Update MongoDB storage provider to set published=False on update or insert if not specified - Add regression test case and necessary test mocks" - invalidate "draftNotes" query key after successful draft note update. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
richardssam
force-pushed
the
notes_publish
branch
from
ee670ac to
71a76f1
Compare
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially addresses #58
I do not handle Include notes from other reviewers, so do need to review that, but otherwise it should be working.
NOTE, I have updated the shotgun provider to use sudo_as_login, so the person publishing the notes needs permissions to do the write. I do need to double check that this is working as expected. Also its worth double checking that your on-prem shotgun server supports this, since older ones may not.