Fix for [ #193 ] viewer goes black if the window is dragged from one screen to another.#195
Open
richardssam wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Conversation
…ndow is dragged from one screen to another on osx. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Osx drag window across screen fix.
[ #193 ] This addresses the issue where the viewer goes black if the window is dragged from one screen to another.
Summarize your change.
The playlist window appears to be configured for a single screen, when you drag the window from one screen to another it will go black, if you drag it back it will become visible again.
I'm using the OnVisibleChanged signal to catch that something has happened, and reinitialize the viewport.
Describe what you have tested and on which operating system.
This has only been tested on OSX, I do not know if there might be issues on windows or linux.
Add a list of changes, and note any that might need special attention during the review.
This seems to work, but while I have a fair bit of experience with PySide I don't have experience with these frameworks, so I could be missing something. There is some logging code, that could go, but it seems like it would be useful for testing on other platforms.