Add errors and assertions to Acc computations#68
Open
ivogabe wants to merge 1 commit intoAccelerateHS:masterfrom
Open
Add errors and assertions to Acc computations#68ivogabe wants to merge 1 commit intoAccelerateHS:masterfrom
ivogabe wants to merge 1 commit intoAccelerateHS:masterfrom
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds throwing errors and assertions to Acc computations. See AccelerateHS/accelerate#494
Motivation and context
These functions should make it easier for users to detect problems in their code. It is also possible to use these functions for parts of the algorithm which haven't been implemented, similar to
undefinedfrom the Prelude, as the program now still compiles and will only crash when such part is actually used.How has this been tested?
Just a quick test, no automated tests yet.
Types of changes
Checklist: