Custom Selection menu items

[RohitKushvaha01]

API Reference

system.addSelectionMenuItem(
    1001,              // Unique ID number
    "Format Code",     // Text shown in menu
    function(result) {
        // This runs when user clicks "Format Code"
        alert("Format Code clicked!");
    },
    function(error) {
        console.error("Error:", error);
    }
);

// REMOVE A MENU ITEM
system.removeSelectionMenuItem(1001);

// 3. DISABLE/ENABLE A MENU ITEM
system.setSelectionMenuItemEnabled(1001, false);
system.setSelectionMenuItemEnabled(1001, true);

// 4. DISABLE/ENABLE ALL CUSTOM ITEMS
system.setAllSelectionMenuItemsEnabled(false);
system.setAllSelectionMenuItemsEnabled(true);

// 5. SHOW/HIDE DEFAULT ANDROID ITEMS (Copy, Paste, etc.)
// Hide Android's default menu items, show only your custom items
system.setDefaultSelectionMenuItemsVisible(false);

// Show Android's default items alongside your custom items
system.setDefaultSelectionMenuItemsVisible(true);

// 6. REMOVE ALL CUSTOM ITEMS
system.clearSelectionMenuItems();

[gemini-code-assist]

Summary of Changes

Hello @RohitKushvaha01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's text editing capabilities on Android by introducing a robust system for customizing the native text selection menu. It provides a new Java class to manage these custom menu items, integrates this functionality directly into the main activity's lifecycle, and exposes a comprehensive set of JavaScript APIs through a Cordova plugin. This allows developers to dynamically add, remove, and control custom actions that appear when text is selected, offering a more tailored user experience.

Highlights

• Custom Selection Menu Implementation: Introduced a new EditorContextMenu class and integrated it into MainActivity.java to allow for custom items in the text selection menu.
• Cordova Plugin Integration: Extended the System Cordova plugin with new methods to manage custom selection menu items from JavaScript.
• Dynamic Menu Control: Added JavaScript APIs to add, remove, enable/disable, and clear custom selection menu items, as well as control the visibility of default items.
• Build Process Update: Modified the post-process.js hook to replace MainActivity.java entirely, streamlining the integration of the custom menu logic.
• Dependency Updates: Updated several development dependencies in package-lock.json.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature for custom text selection menu items, which is a great addition. The implementation includes a new EditorContextMenu manager in Java, along with the necessary Cordova plugin wiring and JavaScript integrations. The overall approach is solid. However, I've identified a critical issue in the new MainActivity.java where a WeakReference to the context is not initialized, which would likely lead to runtime crashes. I've also included a few suggestions to improve the code quality and maintainability of the new Java files.

[gemini-code-assist]

The PluginResult for the onActionItemClicked callback is created with setKeepCallback(true). Since the action mode is finished immediately after the item is clicked, this callback is effectively a one-shot callback. The default behavior (setKeepCallback(false)) is more appropriate here and avoids potential confusion or resource leaks on the JavaScript side if it's not expecting multiple invocations. It's better to remove this line.

[RohitKushvaha01]

@bajrangCoder This PR has one issue: custom menu items should be disabled when the editor is not in use. Otherwise, they appear globally.

I tried adding the enable/disable calls in editorManager.js, but I don’t think the disable call is happening at the correct time.

In short,
system.setAllSelectionMenuItemsEnabled(false);
is not being called from the appropriate place in editorManager.js.