chore: Upgrade from yarn classic (v1.22) to pnpm v10 #66
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,51 @@ | ||
| # How To Contribute | ||
|
|
||
| This repo is a monorepo, for additional instructions, refer to the package.json files in the workspaces, | ||
| or refer to the Github Workflow that runs CI. | ||
|
|
||
| ## Installation | ||
|
|
||
| - `git clone <repository-url>` | ||
| - `cd ember-json-viewer` | ||
| - `pnpm install` | ||
|
|
||
| ## Linting | ||
|
|
||
| Each workspace has a `lint` run-script. | ||
| You can run them all via: | ||
|
|
||
| ``` | ||
| pnpm --filter '*' lint | ||
| ``` | ||
|
|
||
| ## Running tests | ||
|
|
||
| In one terminal, start the addon build: | ||
|
|
||
| ``` | ||
| cd addon/ && pnpm start | ||
| ``` | ||
|
|
||
| In another terminal, start the test-app build: | ||
|
|
||
| ``` | ||
| cd test-app/ && pnpm start | ||
| ``` | ||
|
|
||
| Visit the tests in the browser at localhost:4200/tests. | ||
|
|
||
| Alternatively, run tests via CLI with: `cd test-app/ && pnpm test` | ||
|
|
||
| ## Running the docs application | ||
|
|
||
| Start the addon build in another terminal window: | ||
|
|
||
| ``` | ||
| cd addon/ && pnpm start | ||
| ``` | ||
|
|
||
| Then start the docs app: | ||
|
|
||
| ``` | ||
| cd docs-app/ && pnpm start | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /** | ||
|
Contributor
Author
There was a problem hiding this comment. Added to upgrade eslint 8 to 9 for the addon/ dir, copied with minor changes from test-app's eslint config |
||
| * Debugging: | ||
| * https://eslint.org/docs/latest/use/configure/debug | ||
| * ---------------------------------------------------- | ||
| * | ||
| * Print a file's calculated configuration | ||
| * | ||
| * npx eslint --print-config path/to/file.js | ||
| * | ||
| * Inspecting the config | ||
| * | ||
| * npx eslint --inspect-config | ||
| * | ||
| */ | ||
| import globals from "globals"; | ||
| import js from "@eslint/js"; | ||
|
|
||
| import ember from "eslint-plugin-ember/recommended"; | ||
| import prettier from "eslint-plugin-prettier/recommended"; | ||
| import n from "eslint-plugin-n"; | ||
|
|
||
| import babelParser from "@babel/eslint-parser"; | ||
|
|
||
| const esmParserOptions = { | ||
| ecmaFeatures: { modules: true }, | ||
| ecmaVersion: "latest", | ||
| requireConfigFile: false, | ||
| babelOptions: { | ||
| plugins: [ | ||
| ["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: true }], | ||
| ], | ||
| }, | ||
| }; | ||
|
|
||
| export default [ | ||
| js.configs.recommended, | ||
| prettier, | ||
| ember.configs.base, | ||
| ember.configs.gjs, | ||
| /** | ||
| * Ignores must be in their own object | ||
| * https://eslint.org/docs/latest/use/configure/ignore | ||
| */ | ||
| { | ||
| ignores: ["dist/", "node_modules/", "coverage/", "!**/.*"], | ||
| }, | ||
| /** | ||
| * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options | ||
| */ | ||
| { | ||
| linterOptions: { | ||
| reportUnusedDisableDirectives: "error", | ||
| }, | ||
| }, | ||
| { | ||
| files: ["**/*.js"], | ||
| languageOptions: { | ||
| parser: babelParser, | ||
| }, | ||
| }, | ||
| { | ||
| files: ["**/*.{js,gjs}"], | ||
| languageOptions: { | ||
| parserOptions: esmParserOptions, | ||
| globals: { | ||
| ...globals.browser, | ||
| }, | ||
| }, | ||
| }, | ||
| /** | ||
| * CJS node files | ||
| */ | ||
| { | ||
| files: [ | ||
| "**/*.cjs", | ||
| "config/**/*.js", | ||
| "testem.js", | ||
| "testem*.js", | ||
| ".prettierrc.js", | ||
| ".stylelintrc.js", | ||
| ".template-lintrc.js", | ||
| "ember-cli-build.js", | ||
| "addon-main.js", | ||
| ], | ||
| plugins: { | ||
| n, | ||
| }, | ||
|
|
||
| languageOptions: { | ||
| sourceType: "script", | ||
| ecmaVersion: "latest", | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| }, | ||
| /** | ||
| * ESM node files | ||
| */ | ||
| { | ||
| files: ["**/*.mjs"], | ||
| plugins: { | ||
| n, | ||
| }, | ||
|
|
||
| languageOptions: { | ||
| sourceType: "module", | ||
| ecmaVersion: "latest", | ||
| parserOptions: esmParserOptions, | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sets up node, using the node version from package.json#volta.node