Merged
Conversation
Deploying ui-kit with
|
| Latest commit: |
c22ec16
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ebe0fe11.ui-kit-dwm.pages.dev |
| Branch Preview URL: | https://update-cosmjs.ui-kit-dwm.pages.dev |
samsiegart
force-pushed
the
update-cosmjs
branch
from
87f88fd to
c13262a
Compare
samsiegart
force-pushed
the
update-cosmjs
branch
from
bc08408 to
d30258c
Compare
turadg
approved these changes
Oct 8, 2025
| const { coinMinimalDenom: denom } = stakeCurrency; | ||
| const fee = { | ||
| amount: [{ amount: '0', denom }], | ||
| amount: [{ amount: '15000', denom }], |
Member
There was a problem hiding this comment.
before merging please pull this up into a manifest constant with documentation on how it was derived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: https://github.com/agoric-labs/ymax-poc-ui/issues/58
Updating cosmjs seems to fix the issue. I used resolutions to ensure the latest cosmjs is used because there's some deps that I couldn't untangle importing older cosmjs still.
Tested first in packages/example, then in https://github.com/agoric-labs/ymax-poc-ui/pull/75 after publishing dev releases for the packages.
Also makes the default fee non-zero to try and ensure it doesn't present an approval with zero BLD fees (I noticed this issue during @dckc's demo, but was unable to repro this issue on a fresh keplr install myself)