Add CUDA neighbor loop support#135
Open
AhmedSalih3d wants to merge 1 commit intocodex/optimize-neighborlist-code-performancefrom
Open
Add CUDA neighbor loop support#135AhmedSalih3d wants to merge 1 commit intocodex/optimize-neighborlist-code-performancefrom
AhmedSalih3d wants to merge 1 commit intocodex/optimize-neighborlist-code-performancefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
FlattenNeighborCellLists!and updated exports insrc/SPHNeighborList.jlto produce flattened neighbor offsets/indices for GPU traversal.UpdateNeighbors!to optionally fill aCellListIndicesarray (per-particle cell index) and updatedBuildNeighborCellLists!usage insrc/SPHCellList.jlto callFlattenNeighborCellLists!.UseCUDA::BooltoSimulationMetaDatainsrc/SimulationMetaDataConfiguration.jlto toggle the CUDA path.ShouldUseCUDANeighborLoop) and multiple CUDA kernel entrypoints and device kernels insrc/SPHCellList.jl(severalNeighborLoopPerParticleCUDA!overloads andNeighborLoopKernel*functions) to handle the different metadata/kernel/output/shifting combinations; the original threaded CPU loops remain and are used when CUDA is unavailable or disabled.ParticleFieldsview and aSimMetaDataTypetype for more uniform kernel/call signatures required by the CUDA wrappers.Testing
ls,rg,sed, multipleapply_patchactions, andgit commit -m "Add CUDA neighbor loop support".Codex Task