Localize support buffers in simulation loop#152
Open
AhmedSalih3d wants to merge 8 commits intocodex/refactor-to-avoid-if-statementfrom
Open
Localize support buffers in simulation loop#152AhmedSalih3d wants to merge 8 commits intocodex/refactor-to-avoid-if-statementfrom
AhmedSalih3d wants to merge 8 commits intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RunSimulationso memory lifetime and initialization are colocated with the simulation loop.Description
dρdtI,Velocityₙ⁺,Positionₙ⁺,ρₙ⁺, and shifting arrays insideSimulationLoopusing@allocand conditionally allocate shifting buffers whenSModeis notNoShiftinginsrc/SPHCellList.jl.AllocateSupportDataStructuresfromRunSimulationand simplify theSimulationLoopparameter list so those buffers are no longer passed in.fill!for scalars andcopyto!to primePositionₙ⁺,Velocityₙ⁺, andρₙ⁺) so loop logic continues to use the same temporaries as before.Testing
ls,cat AGENTS.md,rg --files -g 'AGENTS.md',sed -n '1,260p' src/SPHCellList.jl,sed -n '260,620p' src/SPHCellList.jl,rg -n "RunSimulation|SimulationLoop|HalfTimeStep|FullTimeStep|AllocateSupportDataStructures" src/SPHCellList.jl src/PreProcess.jl src/TimeStepping.jl,sed -n '640,940p' src/SPHCellList.jl,sed -n '1,260p' src/PreProcess.jl,sed -n '1,220p' src/TimeStepping.jl,rg -n "DensityEpsi" -n src,sed -n '1,120p' src/SimulationEquations.jl,rg -n "AllocateSupportDataStructures" -n src,rg -n "SimulationLoop\\(" src/SPHCellList.jl,git status --short, andgit diff, and committed the change.Codex Task