Half-step wrappers, neighbor-list robustness, UpdateΔx fallback, and make StillWedge example portable#153
Open
AhmedSalih3d wants to merge 2 commits intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ParticleRangesand accept lazy/wrapper-backed position-like inputs forUpdateΔx!.StillWedgeMDBCexample runnable outside a Windows environment and remove an undefined profiling macro.Description
HalfStepPosition,HalfStepVelocity, andHalfStepDensitywrapper types withIndexStyle/axes/size/getindeximplementations insrc/SPHCellList.jlto compute half-step values on demand and passed those wrappers into neighbor calls.dρdtI,AccelerationMax, gradient buffers) into the mainSimulationLoopand removed per-step temporaries, wiredPressureHalfStep!and a newDensityEpsi!overload into the time-stepping sequence insrc/SPHCellList.jlandsrc/SimulationEquations.jl.UpdateNeighbors!defensive by resizingParticleRangestolength(Particles) + 2, setting the sentinel entry tolength(Particles) + 1, and forcing a rebuild whenSimMetaData.IndexCounter == 0insrc/SPHNeighborList.jl.LinearAlgebra.dotand added a genericUpdateΔx!fallback that accepts wrapper-backed position-like inputs and computes squared norms usingdotinsrc/SPHNeighborList.jl.PressureHalfStep!and added the accompanying half-step pressure/density helper functions insrc/SimulationEquations.jlso callers can invoke them.example/StillWedgeMDBC.jlto remove@profview, use a localOutputDirectory = joinpath(pwd(), "output", "StillWedge2D_MDBC"), and create it withmkpathso the script runs on non-Windows systems.Testing
julia --project=. -e 'include("example/StillWedgeMDBC.jl")', which initially failed due to@profviewbeing undefined, and then succeeded to start after removing the macro and making the output directory portable.Codex Task