Make half-step wrapper views array-like and integrate into time-stepping#154
Open
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MethodErrorwhen using Base array utilities (e.g.keys) on half-step wrapper views and make them interoperable with existing array-based code paths.Description
HalfStepPosition,HalfStepVelocity, andHalfStepDensitytypes as subtypes ofAbstractVectorwith convenience constructors,length/axes/size/IndexStyle, andgetindeximplementations insrc/SPHCellList.jlso they behave like array views.PositionHalfStep, passingHalfStepPosition/HalfStepVelocity/HalfStepDensityintoNeighborLoopPerParticle!, and updating calls that compute pressure and density to use half-step values.PressureHalfStep!and a newDensityEpsi!overload that accept half-step inputs and motion limiters, and replace usages accordingly.SimulationLoopto createAccelerationMax,dρdtI,∇Cᵢ, and∇◌rᵢwithsimilar/fill!and handleNoShiftingmode.SPHNeighborListto resizeParticleRangesinUpdateNeighbors!and add an alternative allocation-freeUpdateΔx!overload that computes norms viadotfor genericposₙ⁺types.example/StillWedgeMDBC.jlto usemkpathand a localOutputDirectoryvariable.Testing
Codex Task