Inline half-step in neighbor loop#156
Open
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Open
Inline half-step in neighbor loop#156AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
AhmedSalih3d wants to merge 1 commit intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HalfTimeSteppass.Positionₙ⁺,Velocityₙ⁺, andρₙ⁺for the next staged pass.Description
NeighborLoopPerParticleHalfStep!variants that mirror existingNeighborLoopPerParticle!signatures (handling NoKernel/KernelOutput and Shifting modes) which accumulatedρdt,Acceleration, kernel/shift outputs where applicable, computeAccelerationMax, apply gravity withConstructGravitySVector, and writePositionₙ⁺,Velocityₙ⁺, andρₙ⁺inline using the provideddt₂.HalfTimeStepsequence in the main simulation loop with a single call toNeighborLoopPerParticleHalfStep!and updated the@timeitlabels to reflect the consolidated step ordering.NeighborLoopPerParticle!implementations intact for the second neighbor pass and preserved dispatch patterns for compatibility across kernel/shifting/MDBC modes.Testing
ls,rg -n "ComputeInteractionsPerParticleNoKernel" src, severalsed -ninspections ofsrc/TimeStepping.jlandsrc/SPHCellList.jl,git status --short,git add src/SPHCellList.jl, andgit commit -m "Inline half-step in neighbor loop".runtestswas executed as part of this change, so no automated tests were run or reported here.Codex Task