Add SIMD-accelerated density update for DensityEpsi!#168
Open
AhmedSalih3d wants to merge 1 commit intomainfrom
Open
Add SIMD-accelerated density update for DensityEpsi!#168AhmedSalih3d wants to merge 1 commit intomainfrom
AhmedSalih3d wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SIMD.jlas a direct dependency to enable portable explicit SIMD intrinsics.Description
DensityEpsi!with a call to a new_density_epsi_simd!helper that usesSIMD.Vec,vloadandvstore!and falls back to a scalar tail loop.using SIMDtosrc/SimulationEquations.jland implemented lane selection based oneltype(Density)(8 lanes forFloat32, 4 otherwise).Project.tomlto addSIMDto[deps]and[compat]and produced a resolvedManifest.tomlduringPkg.resolve/Pkg.instantiate.DensityEpsi!now returnsDensityafter the SIMD update helper completes.Testing
julia --project=. -e 'using Pkg; Pkg.resolve()',julia --project=. -e 'using Pkg; Pkg.instantiate()'andjulia --project=. -e 'using Pkg; Pkg.test()'to validate dependency resolution, instantiation and tests.Pkg.resolve()emitted a registry download 403 warning in this environment butSIMDwas installed and the manifest was updated successfully.SPHExampletests passed (time stepping and isolated particle tests completed successfully).Codex Task