Add WCSPH shifting corrections (density/velocity gradient accumulation and application)#172
Open
AhmedSalih3d wants to merge 4 commits intocodex/refactor-to-avoid-if-statementfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/PreProcess.jlto return new gradient buffers∇ρᵢand∇uᵢfor simulations with shifting.src/SPHCellList.jlto accept the additional gradient buffers and to accumulate per-pair contributions todensity_grad_accandvelocity_grad_accin both kernel and no-kernel interaction paths.FullTimeStepinsrc/TimeStepping.jlto accept the new buffers and apply WCSPH-style corrections by updatingDensity[i] += dot(δxᵢ, ∇ρᵢ[i])andVelocity[i] += (∇uᵢ[i] * δxᵢ)after computing the shiftδxᵢ, while preserving the free-surface guarded shifting behaviour and adding dimension-awareFreeSurfaceThresholdhelpers.FreeSurfaceMode/InternalFlow/FreeSurfaceCorrectiontypes insrc/SimulationMetaDataConfiguration.jland re-export the symbols fromsrc/SPHExample.jl, and update the isolated-particle test intest/runtests.jlto unpack the expanded allocation tuple.Testing
∇ρ/∇ufromAllocateSupportDataStructures), but no automated test suite was executed as part of this change.rg -n "∇ρᵢ" srcandnl -ba src/TimeStepping.jl | sed -n '120,220p'to verify call-site and function signature changes.Codex Task