This repository was archived by the owner on Apr 19, 2024. It is now read-only.
Open
Conversation
mislav
reviewed
Sep 16, 2021
Collaborator
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thanks; this looks good!
What do you think of #377 as an alternative to this approach? It feels like runereader largely just replicates what Go's own x/term package is doing, so to increase portability and to avoid having to maintain this many build tags, we could just offload it to the external package.
Author
|
Yeh that sounds great, happy to test that out once it's merged. |
Fill in the missing ioctlReadTermios/ioctlWriteTermios, and switch to syscall.Syscall as Syscall6 is not available. Probably makes this work on AIX too as a bonus.
Author
|
Hi, any update on this? It's a bit of a pain having to merge these changes every time influxdb switches to a different version of survey. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in the missing ioctlReadTermios/ioctlWriteTermios, and switch to
syscall.Syscall as Syscall6 is not available. Probably makes this work
on AIX too as a bonus.