-
Notifications
You must be signed in to change notification settings - Fork 45
Enabling LTE sensors readout #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a6c5f09
Added LTE sensors
teixeluis bcae74c
Updated manifest
teixeluis e491181
Bumped release version
teixeluis bfca2a6
A few issues
teixeluis 74de31e
bugfixing, troubleshooting
teixeluis d188a94
Initial working version
teixeluis 4f85ac1
added LTE sensors
AlexandrErohin 433aacb
fix
AlexandrErohin c8a39b1
update README
AlexandrErohin b495693
update README
AlexandrErohin 7a144e0
Revert "Initial working version"
teixeluis 4134d64
Revert "bugfixing, troubleshooting"
teixeluis 509ea9d
Revert "A few issues"
teixeluis 7838453
Revert "Bumped release version"
teixeluis 0096fcc
Revert "Updated manifest"
teixeluis 44b3000
Revert "Added LTE sensors"
teixeluis 7457af3
Merge branch 'main' of github.com:teixeluis/home-assistant-tplink-router
teixeluis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| { | ||
| "domain": "tplink_router", | ||
| "name": "TP-Link Router", | ||
| "codeowners": ["@AlexandrErohin"], | ||
| "codeowners": ["@AlexandrErohin","@teixeluis"], | ||
| "config_flow": true, | ||
| "documentation": "https://github.com/AlexandrErohin/home-assistant-tplink-router", | ||
| "documentation": "https://github.com/teixeluis/home-assistant-tplink-router", | ||
| "iot_class": "local_polling", | ||
| "issue_tracker": "https://github.com/AlexandrErohin/home-assistant-tplink-router/issues", | ||
| "issue_tracker": "https://github.com/teixeluis/home-assistant-tplink-router/issues", | ||
| "requirements": ["tplinkrouterc6u==5.9.3"], | ||
| "version": "2.9.0" | ||
| "version": "2.10.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget about compatibility for all routers. Most routers do not have LTE. Only some routers has. So for the most routers these sensors would be Unavailable. It is better to add these sensors separately for LTE routers