Feature improve lte sensor value conversions and mappings#244
Feature improve lte sensor value conversions and mappings#244AlexandrErohin merged 17 commits intoAlexandrErohin:mainfrom
Conversation
|
@AlexandrErohin anything in particular you would like to point out about the PR? |
|
@teixeluis Hi. Thank you for this update. I need some more time. There is a bug with LTE info - #245 I need to fix it before moving forward with it |
| ), | ||
| ) | ||
|
|
||
| network_types = { |
There was a problem hiding this comment.
I thought it would be more useful to move this dict to the client. So I have added this to client
| name="LTE SIM Status", | ||
| icon="mdi:sim-outline", | ||
| value=lambda status: status.sim_status, | ||
| value=lambda status: sim_statuses[status.sim_status], |
There was a problem hiding this comment.
I have added 2 properties to the client network_type_info and sim_status_info - I think it is better to keep here sim_status and network_type for automation use - it is better to check int values then string. And add 2 more sensors for network_type_info and sim_status_info to show str values. What do you think?
There was a problem hiding this comment.
Yes, makes sense, closer to where that responsibility should be. Changed it accordingly, still working ok.
…exandrErohin#244 (comment)) and changes to the lib tplinkrouterc6u
2 participants
Adding this small change that will properly translate the values of some of the sensors, in a similar fashion to what the TP-Link web UI does:
Sensors:
Web UI:
Reference data and calculations extracted from the web UI javascript.
Changes: