Improve request logout safety to prevent update failures#308
Merged
AlexandrErohin merged 1 commit intoAlexandrErohin:mainfrom Feb 2, 2026
Merged
Improve request logout safety to prevent update failures#308AlexandrErohin merged 1 commit intoAlexandrErohin:mainfrom
AlexandrErohin merged 1 commit intoAlexandrErohin:mainfrom
Conversation
Owner
|
@hepter Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TPLinkRouterCoordinator.request.Why
While testing on a BE230 I kept hitting cases where the logout call fails.
The request itself succeeds, but the exception from logout aborts the
update cycle and I end up with no refreshed data. This change keeps the
update loop alive and still surfaces real request errors.
Scope