Skip to content

Comments

Improve request logout safety to prevent update failures#308

Merged
AlexandrErohin merged 1 commit intoAlexandrErohin:mainfrom
hepter:bugfix/logout-guard
Feb 2, 2026
Merged

Improve request logout safety to prevent update failures#308
AlexandrErohin merged 1 commit intoAlexandrErohin:mainfrom
hepter:bugfix/logout-guard

Conversation

@hepter
Copy link
Contributor

@hepter hepter commented Feb 2, 2026

Summary

  • Make logout best‑effort in TPLinkRouterCoordinator.request.
  • Don’t let a logout failure kill a successful update.

Why

While testing on a BE230 I kept hitting cases where the logout call fails.
The request itself succeeds, but the exception from logout aborts the
update cycle and I end up with no refreshed data. This change keeps the
update loop alive and still surfaces real request errors.

Scope

  • Same authorize -> callback -> logout flow.
  • Only changes how logout errors are handled.

@AlexandrErohin AlexandrErohin merged commit 241f020 into AlexandrErohin:main Feb 2, 2026
3 checks passed
@AlexandrErohin
Copy link
Owner

@hepter Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants