Draft
Conversation
Owner
|
I wouldn't make any hasty changes to this logic. It's better to carefully rewrite the core from start to finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a WebRTC client disconnects while a producer is still dialing, the producer keeps running forever with no consumers attached
Fix
Added
IsClosed()to the Consumer interface. AfterDial()completes, we now check if the consumer is still alive before adding tracks. If not, we bail out early so the producer can stop properly.WebRTC implements this by tracking when the WebSocket transport closes during connection setup.
Note:
IsClosed()on the interface allows any consumer to implement proper closed-state detection. Right now only WebRTC needs it, but other consumers (RTSP, HomeKit, etc.) could implement it later if needed. The default incore.Connectionreturnsfalse, so existing consumers work unchanged.