Feature/revise fix and relative TableHeaderColumn width issue#1448
Feature/revise fix and relative TableHeaderColumn width issue#1448bbbbighead wants to merge 2 commits intoAllenFang:masterfrom
Conversation
…ng fix with or relative width(in percentage %) - no need to re-calculate and using fix width when scroll is happening, it will cause side effect which will make header width will only grow but not restore to original size when you resize outside window size(drag window large and small back and forth)
|
@bbbbighead, you found a known issue, actually, I sacrifice this issues to solve most of unalign issues(although there's still have another unalign issues still there....) it's a long story that I will not to describe again lol, but we have a lots of unalign issues due to So I can't merge you PR due to it will cause a lots of unalign issue again.... it's very sorry for you... |
|
hi @AllenFang , got it! Is there any plan when or which version will un-align issues be fixed? v4.0? or other version. Or....is there any idea you want to fix this issue? Our team is using your component quite a long time and feel very great about it. Could you could give me some clues and maybe we might provide some helps for this issue. Thanks for the reply and the effort you made for react community. |
|
Thanks you @bbbbighead 🇹🇼 actually, I usually cant reproduce the unalign issues... and for me, if we want to fix unalign issue thoroughly, the only solution is use one I'm not even think that I can fix it in the future lol Anyway, how about I provide a props for you to let you can control if enable/disable width adjusting? |
fix table header width adjustment logic when TableHeaderColumn is using fix with or relative width(in percentage %)
no need to re-calculate and using fix width when scroll is happening, it will cause side effect which will make header width will only grow but not restore to original size when you resize outside window size(drag window large and small back and forth)
please check the video for how to duplicate the issue
https://youtu.be/-vfrWEJyung