Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f508957 to
f23db8a
Compare
1332271 to
08deb18
Compare
a12c1dd to
193bf80
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
@t-b I also tested pasting the average fit results into Excel. The row formatting is correct. However, Excel plots all the columns in one column. Excel is dumb. To correct this, paste into Excel, select the cells, select Data from the menu, select Text to Columns, and select the appropriate delimiter in the Excel pop-up GUI. |
Collaborator
|
@t-b there may also be issues with the indivdual decay tau values. For example in this case I'm getting a negative weighted tau. |
We now reserve space for the defaults in the psxDeconvBPFilter/psxSweepBPFilter operations so that we can later on add the calculated defaults, which need parameters from psxKernel, can be added via PSX_AddDefaultFilterFrequencies.
And allow querying them from psxstats.
This is convenient for documentation purposes although this is not an input parameter.
Ever since 7aa2be6 (PSX: Add average fit for all states, 2025-06-04) we are using the per-combo index for gathering the eventKernelAmp/eventOnsetTime/eventPeakTime values. This is wrong as we must use the index of the displayed events.
…nce PSX_CalculateOnsetTimeFromAvg
We can just do the fits in a free datafolder so that the current datafolder is not cluttered.
We now don't error out anymore if the Smooth operation fails due to too few points. Also remove code which created global waves.
We always return 10 anyway.
We can easily have this case as the CheckResultsWavesForAverageFitResult test shows.
We currently leak Igor path objects, so let's kill it before returning. Bug introduced in 2436f40 (GetAllFilesRecursivelyFromPath: Rework it completely, 2025-04-16).
1 task
Contributor
5cc8636 to
8d71c75
Compare
timjarsky
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

2^l + 3^klogic()behind numberOfSDs in the JWN to document itV_modeand all other missing entries from StatsQuantiles to postProc output forstatsinpsxStatsTim provides Poc for figuring outpsxKernelparameters from scratchwindows position after move is not kept on pressing display, psx plot onlydoes not reproduceOld Todos
So this should be ready for a first test. I've adapted `psxKernel` and `psxStats` to allow passing in multiple selections.
that still makes sense. The baseline search shouldn't search past the previous
peak_t. With the baseline_t of the event available, PSX_CalculateEventPeak, instead
of using prevDeconvPeak_t to constrain the search, can use the event
baseline_tinstead. The above makes adding a peakfinding operation, which I suggested
yesterday, unnecessary.
// 3 checkboxes to turn all of these on/off below suppress update
// peak_t
// baseline_t
with, see SweepFormula: Groups multiple x-axis labels #2423psxStats, see psxstats: Should accept an array of properties #2422Close: #1663