EnsureLargeEnoughWave: Fix it when requesting powers of two#2604
Merged
Conversation
max is a function with up to 100 optional arguments so let's use this.
When we request a power of two index which is larger than double the wave size and MINIMUM_WAVE_SIZE we would calculate an indexShouldExist which is exactly the same as the requested value. So let's add one before finding the next power of two. Bug introduced in 602d37c (EnsureLargeEnoughWave: Avoid resizing when not needed, 2025-04-16).
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in EnsureLargeEnoughWave where requesting an index that is a power of two would result in insufficient wave size allocation. The issue occurred because FindNextPower returns the same power when given an exact power of two, rather than the next power.
Changes:
- Fixed the power-of-two bug by adding 1 to the index before calling
FindNextPower - Simplified nested
max()calls into a single call with three arguments - Added a comprehensive test case to verify the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Packages/MIES/MIES_Utilities_WaveHandling.ipf | Fixed the calculation in EnsureLargeEnoughWave to handle power-of-two indices correctly and simplified the max() expression |
| Packages/tests/Basic/UTF_Utils_WaveHandling.ipf | Added test ELE_WorksWithPowerOfTwoValue to verify the fix handles power-of-two indices correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will merge once CI passes.