Skip to content

Add unit tests for 22 utility functions in UTF_Utils_WaveHandling.ipf #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-b merged 4 commits into from
Feb 5, 2026
Merged

Add unit tests for 22 utility functions in UTF_Utils_WaveHandling.ipf #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e09ae0
SplitTextWaveBySuffix: Prefer IsEmpty over IsNull
t-b Feb 4, 2026
7378a13
ConvertFreeWaveToPermanent/MoveFreeWaveToPermanent: Enforce that dfr …
t-b Feb 4, 2026
8f6c397
HasEntryInWaveNoteList: Support empty value
t-b Feb 4, 2026
ed26a88
Add comprehensive unit tests for missing functions in UTF_Utils_WaveH…
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Packages/MIES/MIES_Utilities_WaveHandling.ipf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,13 @@ End
/// @sa AddEntryIntoWaveNoteAsList()
Function HasEntryInWaveNoteList(WAVE wv, string key, string value)

return GrepString(note(wv), "\\Q" + key + "\\E\\s*=\\s*\\Q" + value + "\\E\\s*;")
string wvNote = note(wv)

if(IsEmpty(value))
return GrepString(wvNote, "\\Q" + key + "\\E\\s*;")
endif

return GrepString(wvNote, "\\Q" + key + "\\E\\s*=\\s*\\Q" + value + "\\E\\s*;")
End

/// @brief Returns a wave name not used in the given datafolder
Expand Down Expand Up @@ -857,7 +863,7 @@ Function [WAVE/T withSuffix, WAVE/T woSuffix] SplitTextWaveBySuffix(WAVE/T sourc

variable i, numElems

if(IsNull(suffix))
if(IsEmpty(suffix))
Make/FREE/T woSuffix = {""}
return [source, woSuffix]
endif
Expand Down Expand Up @@ -1216,12 +1222,16 @@ End
/// @returns wave reference to the permanent wave
Function/WAVE ConvertFreeWaveToPermanent(WAVE freeWave, DFREF dfr, string wName)

ASSERT(!IsFreeDatafolder(dfr), "dfr must be a global datafolder")

Duplicate/O freeWave, dfr:$wName/WAVE=permWave
return permWave
End

Function/WAVE MoveFreeWaveToPermanent(WAVE freeWave, DFREF dfr, string wvName)

ASSERT(!IsFreeDatafolder(dfr), "dfr must be a global datafolder")

wvName = UniqueWaveName(dfr, wvName)
MoveWave freeWave, dfr:$wvName
WAVE/SDFR=dfr permWave = $wvName
Expand Down
Loading
Loading