Skip to content

DO NOT MERGE Join with duplicated aliases #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilejn wants to merge 1 commit into
base: antalya-25.8
Choose a base branch
from
+8 −1
Open

DO NOT MERGE Join with duplicated aliases #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Interpreters/TreeRewriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,14 @@ TreeRewriterResultPtr TreeRewriter::analyzeSelect(
result.analyzed_join = std::make_shared<TableJoin>();

if (remove_duplicates)
renameDuplicatedColumns(select_query);
{

Aliases aliases;
NameSet name_set;

normalize(query, aliases, name_set, select_options.ignore_alias, settings, /* allow_self_aliases = */ true, getContext(), select_options.is_create_parameterized_view);
renameDuplicatedColumns(select_query);
}

/// Perform it before analyzing JOINs, because it may change number of columns with names unique and break some logic inside JOINs
if (settings[Setting::optimize_normalize_count_variants])
Expand Down
Loading