Skip to content

sort keys in Settings.Keys() method for consistent order (fix manifest reconcile issue) #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mastercactapus wants to merge 1 commit into
base: 0.26.0
Choose a base branch
from
+5 −1
Open

sort keys in Settings.Keys() method for consistent order (fix manifest reconcile issue) #1900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/apis/clickhouse.altinity.com/v1/type_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,15 @@ func (s *Settings) SetScalarsFromMap(m map[string]string) *Settings {
return s
}

// Keys gets keys of the settings
// Keys gets keys of the settings in alphabetical order
func (s *Settings) Keys() (keys []string) {
s.WalkKeys(func(key string, setting *Setting) {
keys = append(keys, key)
})

// Sort keys to ensure deterministic ordering for Kubernetes manifest stability.
// Consistent ordering prevents unnecessary resource updates during reconciliation.
sort.Strings(keys)
return keys
}

Expand Down