Merged
Conversation
refactor: Optimise ChessInput towards O-78
AncientNimbus
added
Enhancement
refactor: Optimise instance variable reset flow in Game class
refactor: Simplify fen_data variables assignment structure refactor: enhance board analysis return structure
This iteration fixes an issue where fen string won't be saved if the imported session is at its endgame position (draw or checkmate)
towards O-76
feat(UX): Replace prefix with unique icons feat(UX): Add WaitUtils class to handle loading messages test: Update test cases to support wait events
This iteration fix the Stalemate delayed print issue, further testing may be required, closing O-78 for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the chess console game, focusing on improving the export functionality, simplifying input handling, and refactoring code for better maintainability. Key changes include updates to the export output format, removal of redundant attributes, and the introduction of a utility method to handle input mode switching.
Major changes:
ChessInputinput_parserfromChessInput